Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix circular dependency between Eventing and commerce mock in the fast-integration tests #13972

Merged
merged 1 commit into from Apr 13, 2022
Merged

Fix circular dependency between Eventing and commerce mock in the fast-integration tests #13972

merged 1 commit into from Apr 13, 2022

Conversation

marcobebway
Copy link
Contributor

@marcobebway marcobebway commented Apr 13, 2022 •
edited

Description

Fix circular dependency between Eventing and commerce mock in the fast-integration tests.

Examples

  • Sample run before fixing the circular dependency is here.
  • Sample run after fixing the circular dependency is here.

@kyma-bot kyma-bot requested a review from dennis-ge April 13, 2022 09:30
@kyma-bot kyma-bot added the area/eventing Issues or PRs related to eventing label Apr 13, 2022
@kyma-bot kyma-bot added area/tests Issues or PRs related to tests size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 13, 2022
@marcobebway
Copy link
Contributor Author

/test pre-main-kyma-skr-eventing

@marcobebway
Copy link
Contributor Author

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@marcobebway
Copy link
Contributor Author

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@marcobebway
Copy link
Contributor Author

/hold cancel

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2022
@marcobebway
Copy link
Contributor Author

/auto-cc

@marcobebway
Copy link
Contributor Author

/auto-cc

@marcobebway
Copy link
Contributor Author

/auto-cc

@kyma-bot kyma-bot requested a review from tobiscr April 13, 2022 10:11
@kyma-bot kyma-bot added the lgtm Looks good to me! label Apr 13, 2022
@mfaizanse mfaizanse removed their assignment Apr 13, 2022
@marcobebway
Copy link
Contributor Author

/assign @clebs

@marcobebway
Copy link
Contributor Author

/assign @rakesh-garimella

@kyma-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfaizanse, rakesh-garimella

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyma-bot kyma-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2022
@kyma-bot kyma-bot merged commit b29424b into kyma-project:main Apr 13, 2022
@marcobebway marcobebway deleted the fix-eventing-fi-circular-dep branch April 13, 2022 11:44
koala7659 pushed a commit to koala7659/kyma that referenced this pull request May 5, 2022
@marcobebway @koala7659
Fix circular dependency between Eventing and commerce mock in the fas…
998bebe 
…t-integration tests (kyma-project#13972)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

@dennis-ge dennis-ge Awaiting requested review from dennis-ge

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@raypinto raypinto Awaiting requested review from raypinto

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Awaiting requested review from Tomasz-Smelcerz-SAP

@tobiscr tobiscr Awaiting requested review from tobiscr

Assignees

@clebs clebs

@rakesh-garimella rakesh-garimella

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/eventing Issues or PRs related to eventing area/tests Issues or PRs related to tests lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marcobebway @kyma-bot @mfaizanse @rakesh-garimella @clebs