Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component test for checking lack of sidecars in kube-system #14497

Merged
merged 11 commits into from Jun 14, 2022

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Jun 6, 2022

Description

Changes proposed in this pull request:

  • small fixes to the eval istio test
  • checking that existing pods and newly deployed httpbin in kube-system
    don't have istio sidecars

Related issue(s)

@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2022
@cnvergence cnvergence force-pushed the istio-sidecar-tests branch 3 times, most recently from 5942510 to 70ab80f Compare June 9, 2022 12:49
@cnvergence cnvergence marked this pull request as ready for review June 10, 2022 16:06
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2022
@cnvergence cnvergence added the area/service-mesh Issues or PRs related to service-mesh label Jun 10, 2022
@netlify
Copy link

netlify bot commented Jun 13, 2022

🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 695d18c
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/62a8973ef6db2600098738f0
😎 Deploy Preview https://deploy-preview-14497--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cnvergence cnvergence added the area/tests Issues or PRs related to tests label Jun 13, 2022
@kyma-bot
Copy link
Contributor

@cnvergence: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-kyma-tests-components-application-connector 19354eb link true /test pre-kyma-tests-components-application-connector
pre-main-kyma-integration-k3d-istio-evaluation 28fa6b1 link false /test pre-main-kyma-integration-k3d-istio-evaluation
pre-main-kyma-integration-k3d-istio-production 28fa6b1 link false /test pre-main-kyma-integration-k3d-istio-production

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cnvergence
Copy link
Contributor Author

/test all

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 14, 2022
@kyma-bot kyma-bot merged commit 9c69881 into kyma-project:main Jun 14, 2022
@cnvergence cnvergence deleted the istio-sidecar-tests branch June 14, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh area/tests Issues or PRs related to tests lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants