Remove the omitempty from SubscriptionStatus CleanEventTypes #14881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcobebway
requested review from
k15r,
nachtmaar,
mfaizanse,
friedrichwilken,
vpaskar,
raypinto and
lilitgh
as code owners
kyma-bot
added
the
size/L
3 tasks
|
/test pre-main-kyma-validate-image-existence |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
marcobebway
force-pushed
the
14293-subscription-crd-make-clean-event-types-not-optional
branch
from
9833874
to
5a8450a
Compare
friedrichwilken
requested changes
Jul 25, 2022
components/eventing-controller/api/v1alpha1/subscription_types.go
Outdated
Show resolved
Hide resolved
|
/hold |
kyma-bot
added
the
do-not-merge/hold
friedrichwilken
approved these changes
Jul 25, 2022
|
/lgtm |
|
/retest-required |
|
/test pre-main-kyma-integration-k3d-central-app-connectivity-compass |
|
/hold cancel |
kyma-bot
removed
the
do-not-merge/hold
|
@marcobebway: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test pre-main-kyma-integration-k3d-central-app-connectivity-compass |
marcobebway
deleted the
14293-subscription-crd-make-clean-event-types-not-optional
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
omitemptyfrom the SubscriptionStatus CleanEventTypes.Related issue(s)