Cra test gql to compass #15119
Merged
Cra test gql to compass #15119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koala7659
requested review from
mmitoraj,
majakurcius,
NHingerl,
grego952,
VOID404,
akgalwas,
janmedrek,
franpog859 and
mvshao
as code owners
kyma-bot
added
size/XXL
5 tasks
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
koala7659
force-pushed
the
cra-test-gql-to-compass
branch
from
363ddac
to
cb0f97d
Compare
kyma-bot
removed
the
do-not-merge/work-in-progress
…Runtime, UnregisterRuntime
mvshao
added
area/application-connector
franpog859
reviewed
Sep 15, 2022
| @@ -5,7 +5,7 @@ MOCK_APP_IMAGE = "$(DOCKER_PUSH_REPOSITORY)$(DOCKER_PUSH_DIRECTORY)/mock-app:$(D | |||
|
|
|||
| .PHONY: release image | |||
|
|
|||
| release: publish-gateway-test publish-mock-app publish-validator-test publish-compass-runtime-agent-test | |||
| release: publish-compass-runtime-agent-test | |||
There was a problem hiding this comment.
I think we should revert this change
tests/components/application-connector/resources/charts/compass-runtime-agent-test/values.yaml
Outdated
Show resolved
Hide resolved
tests/components/application-connector/resources/charts/compass-runtime-agent-test/values.yaml
Outdated
Show resolved
Hide resolved
tests/components/application-connector/test/compass-runtime-agent/suite_test.go
Show resolved
Hide resolved
tests/components/application-connector/test/compass-runtime-agent/suite_test.go
Outdated
Show resolved
Hide resolved
...lication-connector/test/compass-runtime-agent/testkit/third_party/machinebox/graphql/LICENSE
Show resolved
Hide resolved
franpog859
reviewed
Sep 15, 2022
tests/components/application-connector/test/compass-runtime-agent/config.go
Show resolved
Hide resolved
|
|
||
| exec := func() error { | ||
| id, err := gs.directorClient.RegisterApplication(compassAppName) | ||
| id, err := gs.directorClient.RegisterApplication(compassAppName, scenarioName) |
There was a problem hiding this comment.
Shouldn't it also be assigned to the correct formation to appear in the runtime? I didn't check it manually yet, just reading the code
There was a problem hiding this comment.
I'm not sure since I did not write this particular piece. We will see during tests
...omponents/application-connector/test/compass-runtime-agent/testkit/director/queryprovider.go
Show resolved
Hide resolved
tests/components/application-connector/test/compass-runtime-agent/testkit/oauth/types.go
Show resolved
Hide resolved
|
@koala7659: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
majakurcius
approved these changes
Sep 21, 2022
Abirdcfly
pushed a commit
to Abirdcfly/kyma
that referenced
this pull request
Oct 5, 2022
* first approach for moving graphQL client to test application * Adding director dependency * extracting oauth client to new component and making it build * continue work on graphql client implementation * finally make build graphQL client * update base image go version to the latest one * minimal set of gql client ready for tests. Unit tests pass * regenerated go mocks * adding test configuration * restore restart policy removed by accident * adding RBAC to read secrets and fixes for getting tokens * remove comments and testing app delete * adjustments of the compass runtime agent test suite for compass director client * adding rule to clusterRole to allow reading applications * Addling labeling test namespace for istio injection * Build fix * remove label from application * Remove application labels for scenarios, tenant optimisation, regenerate mocks, and unit tests fixes * Reenable commented out code in Synchronization test * Small fix for oauth clinet unit test * go mod tidy run * fixes after merge * New mutation for creating application * Adding new Director mutations: AssignApplicationToFormation, RegisterRuntime, UnregisterRuntime * Adding new Director mutations: AssignRuntimeToFormation, GetConnectionToken * Commented out testing code * makefile fix * review suggestions * change GetConnectionToken function declaration to match second PR * Add two new mutations Register/Unregister Formation * Small change in argument name * Restore old makefile content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the implementation of GraphQL client used by compass-runtime-agent component tests to connect to Compass Director API and perform various operations needed for testing scenarios:
There is a hidden assumption here: the testing scenario always exists, and we are not adding/removing it from compass. It might be problematic