Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare code initializing Compass Runtime Agent before Compass Runtime Agent runs #15390

Merged
merged 69 commits into from Oct 19, 2022
Merged

Prepare code initializing Compass Runtime Agent before Compass Runtime Agent runs #15390

merged 69 commits into from Oct 19, 2022

Conversation

akgalwas
Copy link
Contributor

@akgalwas akgalwas commented Sep 7, 2022

Description

Changes proposed in this pull request:

  • Creating formation
  • Registering Runtime
  • Unregistering Runtime
  • Restarting Compass Runtime Agent

Related issue(s)
#15037

koala7659 and others added 19 commits August 16, 2022 18:54
@koala7659
first approach for moving graphQL client to test application
d2617b2
@koala7659
Adding director dependency
5b8b994
@koala7659
extracting oauth client to new component and making it build
24a0a53
@koala7659
Merge remote-tracking branch 'upstream/main' into cra-test-gql-to-com…
c25ec11 
…pass
@koala7659
continue work on graphql client implementation
e7e8adc
@koala7659
finally make build graphQL client
bd43506
@koala7659
update base image go version to the latest one
699b720
@koala7659
minimal set of gql client ready for tests. Unit tests pass
6cb8cc7
@koala7659
regenerated go mocks
c4591e4
@koala7659
adding test configuration
a619e31
@koala7659
restore restart policy removed by accident
6698978
@koala7659
adding RBAC to read secrets and fixes for getting tokens
cb0f97d
@koala7659
Merge remote-tracking branch 'upstream/main' into cra-test-gql-to-com…
f7dd5f7 
…pass
@koala7659
remove comments and testing app delete
714fec8
@koala7659
Merge remote-tracking branch 'upstream/main' into cra-test-gql-to-com…
534966c 
…pass
@koala7659
adjustments of the compass runtime agent test suite for compass direc…
db79f20 
…tor client
@koala7659
adding rule to clusterRole to allow reading applications
406d84a
@koala7659
Addling labeling test namespace for istio injection
e3c3a2d
@akgalwas
Merge remote-tracking branch 'przemek/cra-test-gql-to-compass' into i…
1f41710 
…nit-code-in-cra-test
@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 7, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 7, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 7, 2022
@netlify
Copy link

netlify bot commented Sep 9, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit e3db4df
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63481a8b66d8370008df1c8d
😎 Deploy Preview https://deploy-preview-15390--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2022
@akgalwas
Copy link
Contributor Author

akgalwas commented Oct 5, 2022

/retest

@franpog859 franpog859 modified the milestones: 2.8, Future Oct 13, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 14, 2022 •
edited

@akgalwas: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-telemetry ac6f490 link true /test pre-main-kyma-integration-k3d-telemetry
pull-telemetry-operator-unit-test ac6f490 link true /test pull-telemetry-operator-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

koala7659
koala7659 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@koala7659 koala7659 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Kudos for Go Generics!

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 19, 2022
@kyma-bot kyma-bot merged commit 76c187d into kyma-project:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franpog859 franpog859 franpog859 left review comments

@koala7659 koala7659 koala7659 approved these changes

@VOID404 VOID404 Awaiting requested review from VOID404

@janmedrek janmedrek Awaiting requested review from janmedrek

@mvshao mvshao Awaiting requested review from mvshao

@PK85 PK85 Awaiting requested review from PK85

@dbadura dbadura Awaiting requested review from dbadura

Assignees

@koala7659 koala7659

Labels
area/application-connector Issues or PRs related to application connectivity area/tests Issues or PRs related to tests lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@akgalwas @kyma-bot @koala7659 @franpog859 @mvshao