Added EventMesh backend/handler for Subscription v1alpha2 #15596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaizanse
requested review from
k15r,
nachtmaar,
marcobebway,
friedrichwilken,
vpaskar,
raypinto and
lilitgh
as code owners
mfaizanse
added
the
do-not-merge/hold
kyma-bot
added
the
size/XXL
4 tasks
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
raypinto
reviewed
Sep 28, 2022
components/eventing-controller/pkg/backend/cleaner/eventmesh.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/pkg/backend/utils/eventmesh_utils.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/pkg/backend/utils/eventmesh_utils.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/pkg/backend/utils/eventmesh_utils.go
Outdated
Show resolved
Hide resolved
|
/test pre-main-kyma-gardener-azure-alpha-eval |
|
/test pull-eventing-controller-unit-test |
raypinto
reviewed
Sep 29, 2022
components/eventing-controller/pkg/backend/eventmesh/eventmesh.go
Outdated
Show resolved
Hide resolved
components/eventing-controller/pkg/backend/eventmesh/eventmesh.go
Outdated
Show resolved
Hide resolved
mfaizanse
removed
the
do-not-merge/hold
raypinto
approved these changes
Sep 29, 2022
|
/test pre-main-kyma-gardener-gcp-eventing |
|
/test pre-main-kyma-gardener-gcp-eventing-upgrade |
4 tasks
|
/retest |
|
@mfaizanse: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Abirdcfly
pushed a commit
to Abirdcfly/kyma
that referenced
this pull request
Oct 5, 2022
…ct#15596) * Added EventMesh backend/handler for Subscription v1alpha2 * Fixed tests * added tests * updated eventMeshPrefix * added tests * added cleaner logic for BEB * added tests * lint fix * added tests * image bump * fixed some lint issues * addressed review comments part 1 * addressed review comments part 2 * lint fix * bug fix and updated test * addressed review comments part 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
backend/utilsfor better usability and to support v1alpha2.Related issue(s)