New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make service catalog as a root chart #1562
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment, you have flatten all SC addons applications into core chart. PLease revert that and move them into service-catalog-addons.
Also adjust documentation in SC chart and SCA chart, to reflect a core of SC + DB, and SC addons applications.
Next thing, right now, we dont need to register brokers in core helm release in update phase, reason: SC APIs are already available. Move broker registratin into helm install phase.
create a doc with description of custom service catalog installation, see https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/037-inst-custom-istio.md |
The Binding Usage Controller chart provides two default UsageKinds to Kyma: | ||
|
||
* function-usage-kind.yaml | ||
* deployment-usage-kind.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a link would be useful here to send the reader off to the proper documentation?
For more information on these CRs, go to the {name} directory.
Description
Changes proposed in this pull request:
I have measured the time within Kyma is installed with SC extracted from the core chart and with an old approach.
Extracted SC:
SC installation ~ 1min
Core installation ~ 4-4,5min
Kyma (all charts) installation ~8min
Old approach (SC in the core chart):
Core installation ~5-5.5min
Kyma installation ~8min
Both approaches provides comparable installation times :)
Related issue(s)
#809