Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make service catalog as a root chart #1562

Merged
merged 3 commits into from Nov 16, 2018
Merged

Make service catalog as a root chart #1562

merged 3 commits into from Nov 16, 2018

Conversation

polskikiel
Copy link
Contributor

@polskikiel polskikiel commented Nov 7, 2018

Description

Changes proposed in this pull request:

  • Moved Service Catalog from core chart to the root
  • Moved Instances-UI, Catalog-UI, Brokers-UI, BUC to the service-catalog-addons subchart of the core chart.
  • Aligned the docs
  • Submitted the issue about unnecessary helm upgrade step in installer Remove hardocoded "upgrade" step for core #1609

I have measured the time within Kyma is installed with SC extracted from the core chart and with an old approach.

Extracted SC:
SC installation ~ 1min
Core installation ~ 4-4,5min
Kyma (all charts) installation ~8min

Old approach (SC in the core chart):
Core installation ~5-5.5min
Kyma installation ~8min

Both approaches provides comparable installation times :)

Related issue(s)

#809

Copy link
Contributor

@PK85 PK85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment, you have flatten all SC addons applications into core chart. PLease revert that and move them into service-catalog-addons.

Also adjust documentation in SC chart and SCA chart, to reflect a core of SC + DB, and SC addons applications.

Next thing, right now, we dont need to register brokers in core helm release in update phase, reason: SC APIs are already available. Move broker registratin into helm install phase.

@polskikiel polskikiel removed the WIP label Nov 9, 2018
@piotrmiskiewicz
Copy link
Member

create a doc with description of custom service catalog installation, see https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/037-inst-custom-istio.md

docs/kyma/docs/038-inst-custom-service-catalog.md Outdated Show resolved Hide resolved
docs/kyma/docs/038-inst-custom-service-catalog.md Outdated Show resolved Hide resolved
docs/kyma/docs/038-inst-custom-service-catalog.md Outdated Show resolved Hide resolved
docs/kyma/docs/038-inst-custom-service-catalog.md Outdated Show resolved Hide resolved
docs/kyma/docs/038-inst-custom-service-catalog.md Outdated Show resolved Hide resolved
resources/core/charts/service-catalog-addons/README.md Outdated Show resolved Hide resolved
The Binding Usage Controller chart provides two default UsageKinds to Kyma:

* function-usage-kind.yaml
* deployment-usage-kind.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a link would be useful here to send the reader off to the proper documentation?

For more information on these CRs, go to the {name} directory.

resources/service-catalog/README.md Outdated Show resolved Hide resolved
resources/service-catalog/README.md Outdated Show resolved Hide resolved
resources/service-catalog/README.md Outdated Show resolved Hide resolved
@polskikiel polskikiel merged commit 4733f40 into kyma-project:master Nov 16, 2018
@polskikiel polskikiel deleted the sc-module branch November 16, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-management Issues or PRs related to service management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants