Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sink validator and crd for subscription v1alpha2 #15665

Merged
merged 4 commits into from Sep 28, 2022

Conversation

raypinto
Copy link
Contributor

@raypinto raypinto commented Sep 28, 2022

Description

Changes proposed in this pull request:

  • Added sinkValidator for v1alpha2
  • Added CRD for v1alpha2

Related issue(s)

#15363 #15364

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 28, 2022
@raypinto raypinto added the area/eventing Issues or PRs related to eventing label Sep 28, 2022
@netlify
Copy link

netlify bot commented Sep 28, 2022

🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 868f1d1
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/633426ca5679f10008860e2d
😎 Deploy Preview https://deploy-preview-15665--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 28, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 28, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 28, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 28, 2022
@raypinto
Copy link
Contributor Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 28, 2022

@raypinto: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-skr-eventing 858f92f link false /test pre-main-kyma-skr-eventing
pull-eventing-controller-lint 858f92f link false /test pull-eventing-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit a949710 into kyma-project:main Sep 28, 2022
@raypinto raypinto deleted the sink-validator-v1alpha2 branch September 28, 2022 17:26
Abirdcfly pushed a commit to Abirdcfly/kyma that referenced this pull request Oct 5, 2022
)

* add sink validator and crd for v1alpha2

* add missing functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants