Add a section on Response rewriting to Application Gateway details #15750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majakurcius
added
area/documentation
majakurcius
requested review from
mmitoraj,
NHingerl,
grego952 and
IwonaLanger
as code owners
kyma-bot
added
the
size/XS
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
janmedrek
reviewed
Oct 7, 2022
docs/05-technical-reference/ac-01-application-gateway-details.md
Outdated
Show resolved
Hide resolved
janmedrek
reviewed
Oct 7, 2022
kyma-bot
added
the
do-not-merge/invalid-commit-message
Co-authored-by: Jan Mędrek <jan.medrek@sap.com>
majakurcius
force-pushed
the
issue-14717-response-rewriting
branch
from
15f9892
to
f597be2
Compare
kyma-bot
added
size/S
grego952
reviewed
Oct 7, 2022
|
|
||
| ## Response rewriting | ||
|
|
||
| If during a call to the external system, the target responds with a redirect (`3xx` status code) that points to the URL with the same host and a different path, the `Location` header is modified so that the original target path is replaced with the Application Gateway URL and port, with the sub-path pointing to the called service attached at the end, in this format: `{APP_GATEWAY_URL}:{APP_GATEWAY_PORT}/{APP_NAME}/{SERVICE_NAME}/{SUB-PATH}`. |
There was a problem hiding this comment.
Suggested change
| If during a call to the external system, the target responds with a redirect (`3xx` status code) that points to the URL with the same host and a different path, the `Location` header is modified so that the original target path is replaced with the Application Gateway URL and port, with the sub-path pointing to the called service attached at the end, in this format: `{APP_GATEWAY_URL}:{APP_GATEWAY_PORT}/{APP_NAME}/{SERVICE_NAME}/{SUB-PATH}`. | |
| If during a call to the external system, the target responds with a redirect (`3xx` status code) that points to the URL with the same host and a different path, the `Location` header is modified so that the original target path is replaced with the Application Gateway URL and port. The sub-path points to the called service attached at the end, in this format: `{APP_GATEWAY_URL}:{APP_GATEWAY_PORT}/{APP_NAME}/{SERVICE_NAME}/{SUB-PATH}`. |
I'd split this long sentence :D
There was a problem hiding this comment.
It can't be split this way, because that's not what it means, but you drew my attention to its ambiguity!
There was a problem hiding this comment.
It's the sub-path that's attached and it's important to have it all in once sentence, even though I also hate that it's long :(
|
|
||
| If during a call to the external system, the target responds with a redirect (`3xx` status code) that points to the URL with the same host and a different path, the `Location` header is modified so that the original target path is replaced with the Application Gateway URL and port, with the sub-path pointing to the called service attached at the end, in this format: `{APP_GATEWAY_URL}:{APP_GATEWAY_PORT}/{APP_NAME}/{SERVICE_NAME}/{SUB-PATH}`. | ||
|
|
||
| This functionality makes the HTTP clients that originally called Application Gateway follow redirects through the Gateway, and not to the service directly. This allows for passing authorization, custom headers, URL parameters, and the body without an issue. |
There was a problem hiding this comment.
Suggested change
| This functionality makes the HTTP clients that originally called Application Gateway follow redirects through the Gateway, and not to the service directly. This allows for passing authorization, custom headers, URL parameters, and the body without an issue. | |
| This functionality makes the HTTP clients that originally called Application Gateway follow redirects through the Gateway, and not to the service directly. This allows for passing authorization, custom headers, URL parameters, and the body. |
I'd drop the without an issue part. It sounds like sth could go wrong. We don't want that :D
There was a problem hiding this comment.
It could go wrong if there is no response rewriting.
grego952
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a section on Response rewriting to Application Gateway details.
Changes proposed in this pull request:
Related issue(s)
#14717