Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add one more useful debug log for the function-controller #15868

Merged
merged 2 commits into from Oct 21, 2022
Merged

Add one more useful debug log for the function-controller #15868

merged 2 commits into from Oct 21, 2022

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Oct 21, 2022

Description

Changes proposed in this pull request:

  • as in the title

@pPrecel pPrecel added area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 21, 2022
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 21, 2022
@pPrecel pPrecel added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
@pPrecel pPrecel removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
m00g3n
m00g3n approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 21, 2022
@kyma-bot
Copy link
Contributor

@pPrecel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-validate-image-existence e1f239d link false /test pre-main-kyma-validate-image-existence
pull-function-controller-lint e1f239d link false /test pull-function-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 2e31758 into kyma-project:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

@dbadura dbadura Awaiting requested review from dbadura

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@moelsayed moelsayed Awaiting requested review from moelsayed

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

Assignees

@m00g3n m00g3n

Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pPrecel @kyma-bot @m00g3n