Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing timeout when notifying health channel #15876

Merged
merged 9 commits into from Oct 26, 2022
Merged

Add missing timeout when notifying health channel #15876

merged 9 commits into from Oct 26, 2022

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Oct 21, 2022

Description

Changes proposed in this pull request:

  • Add missing timeout when notifying health channel after health event received
  • Reason

Related issue(s)

#15590

@pPrecel pPrecel added kind/bug Categorizes issue or PR as related to a bug. area/serverless Issues or PRs related to serverless labels Oct 21, 2022
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2022
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 25, 2022
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2022
@netlify
Copy link

netlify bot commented Oct 25, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit 2977798
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/635901bba3abd20009e27890
😎 Deploy Preview https://deploy-preview-15876--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

m00g3n
m00g3n approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pPrecel
Copy link
Contributor Author

pPrecel commented Oct 26, 2022

/retest

2 similar comments
@dbadura
Copy link
Contributor

dbadura commented Oct 26, 2022

/retest

@pPrecel
Copy link
Contributor Author

pPrecel commented Oct 26, 2022

/retest

@pPrecel
Copy link
Contributor Author

pPrecel commented Oct 26, 2022

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Oct 26, 2022 •
edited

@pPrecel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-function-controller-lint 2977798 link false /test pull-function-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pPrecel pPrecel added the lgtm Looks good to me! label Oct 26, 2022
@kyma-bot kyma-bot merged commit 600629f into kyma-project:main Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

@dbadura dbadura Awaiting requested review from dbadura

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@moelsayed moelsayed Awaiting requested review from moelsayed

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

Assignees

@m00g3n m00g3n

Labels
area/serverless Issues or PRs related to serverless kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pPrecel @dbadura @kyma-bot @m00g3n