Caching the OAuth tokens in Application Gateway #15924
Conversation
mvshao
added
the
area/application-connector
mvshao
requested review from
mmitoraj,
majakurcius,
NHingerl,
grego952,
IwonaLanger,
VOID404,
akgalwas,
koala7659 and
franpog859
as code owners
kyma-bot
added
the
size/L
✅ 🥰 Documentation preview ready! 🥰
To edit notification comments on pull requests, go to your Netlify site settings. |
| crt: {{ $files.Get "certs/invalid-ca/client.crt" | b64enc }} | ||
| key: {{ $files.Get "certs/invalid-ca/client.key" | b64enc }} | ||
| clientId: {{ "clientID" | b64enc }} |
There was a problem hiding this comment.
I think in the tests, we can change all the clientIDs from someClientID... to just clientID, right?
There was a problem hiding this comment.
Yes, we can also change that
| crt: {{ $files.Get "certs/invalid-ca/client.crt" | b64enc }} | ||
| key: {{ $files.Get "certs/invalid-ca/client.key" | b64enc }} |
There was a problem hiding this comment.
Why is the ...negative... changed to the ...invalid-ca... there?
There was a problem hiding this comment.
The same CA signs a positive certificate and a negative certificate. For this test, I generated certificates that are signed by other CA.
| @@ -5,5 +5,5 @@ metadata: | |||
| namespace: kyma-integration | |||
| type: Opaque | |||
| data: | |||
| clientId: {{ "bad id" | b64enc }} | |||
| clientId: {{ "clientID" | b64enc }} | |||
There was a problem hiding this comment.
I believe this one should not be changed :d It's the oauth-negative-incorrect-id case
|
/test pre-main-kyma-integration-k3d |
|
/test pre-main-kyma-integration-k3d |
Description
Changes proposed in this pull request:
clientID + clientSecret + authURLclientID + sha256Certificate + sha256Key + authURLRelated issue(s)
For more information visit https://extra.secret.repository/kyma/backlog/issues/2774