Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from RegisteredLoggers to the AtomicLevel #16004

Merged
merged 5 commits into from Nov 14, 2022
Merged

Migrate from RegisteredLoggers to the AtomicLevel #16004

merged 5 commits into from Nov 14, 2022

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Nov 3, 2022

Description

Changes proposed in this pull request:

  • as in the title

Related issue(s)

#15823

@pPrecel pPrecel added area/serverless Issues or PRs related to serverless area/logging Issues or PRs related to the logging module (deprecated) kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 3, 2022
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 3, 2022
@netlify
Copy link

netlify bot commented Nov 3, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit c475077
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63716cd9cbb3f3000874d212
😎 Deploy Preview https://deploy-preview-16004--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

moelsayed
moelsayed previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@moelsayed moelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added lgtm Looks good to me! labels Nov 7, 2022
@dbadura dbadura assigned pPrecel and unassigned moelsayed Nov 8, 2022
@pPrecel
Copy link
Contributor Author

pPrecel commented Nov 8, 2022

/retest

@pPrecel
Copy link
Contributor Author

pPrecel commented Nov 9, 2022

/test all

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 9, 2022
@halamix2
Copy link
Member

halamix2 commented Nov 9, 2022

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 9, 2022
@kyma-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Nov 13, 2022
@kyma-bot
Copy link
Contributor

@pPrecel: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-pjtester 346a3b5 link true /test pull-kyma-pjtester
pull-function-controller-lint c475077 link false /test pull-function-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pPrecel pPrecel added the lgtm Looks good to me! label Nov 14, 2022
@kyma-bot kyma-bot merged commit 432a047 into kyma-project:main Nov 14, 2022
@pPrecel pPrecel mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelsayed moelsayed moelsayed approved these changes

@m00g3n m00g3n Awaiting requested review from m00g3n

@dbadura dbadura Awaiting requested review from dbadura

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

Assignees

@moelsayed moelsayed

@halamix2 halamix2

@pPrecel pPrecel

Labels
area/logging Issues or PRs related to the logging module (deprecated) area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pPrecel @halamix2 @kyma-bot @moelsayed