Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved loki deprecation notes #16072

Merged
merged 3 commits into from Nov 14, 2022
Merged

Improved loki deprecation notes #16072

merged 3 commits into from Nov 14, 2022

Conversation

a-thaler
Copy link
Contributor

Description

Changes proposed in this pull request:

  • adjusted logging architecture docu as it was spoiled
  • removed the prominent deprecation note from the telemetry documentation as Loki is not the focus here
  • few other improvements in the documentation

Related issue(s)
#15893

@a-thaler a-thaler added area/documentation Issues or PRs related to documentation area/logging Issues or PRs related to the logging module (deprecated) labels Nov 11, 2022
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 11, 2022
@netlify
Copy link

netlify bot commented Nov 11, 2022 •
edited

✅ 🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit aef04cf
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/636e5b12e0e2ce000804869d
😎 Deploy Preview https://deploy-preview-16072--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 11, 2022
@kyma-bot kyma-bot merged commit 25c0f99 into kyma-project:main Nov 14, 2022
@a-thaler a-thaler deleted the docu branch November 14, 2022 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

@grego952 grego952 grego952 approved these changes

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@majakurcius majakurcius Awaiting requested review from majakurcius

@NHingerl NHingerl Awaiting requested review from NHingerl

@IwonaLanger IwonaLanger Awaiting requested review from IwonaLanger

Assignees

@rakesh-garimella rakesh-garimella

@grego952 grego952

Labels
area/documentation Issues or PRs related to documentation area/logging Issues or PRs related to the logging module (deprecated) lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@a-thaler @rakesh-garimella @grego952 @kyma-bot