Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SecretMounts to function API #16108

Merged
merged 6 commits into from Nov 25, 2022
Merged

Conversation

anoipm
Copy link
Contributor

@anoipm anoipm commented Nov 16, 2022

Description

Changes proposed in this pull request:

  • add SecretMounts to function API (it is propagated to Volumes and VolumeMounts in function's pod)

Related issue(s)
See also #14998

Manual test
See here

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 16, 2022
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2022
@anoipm
Copy link
Contributor Author

anoipm commented Nov 16, 2022

/test all

1 similar comment
@anoipm
Copy link
Contributor Author

anoipm commented Nov 16, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 16, 2022

/test pre-main-kyma-validate-image-existence

@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 17, 2022
@anoipm
Copy link
Contributor Author

anoipm commented Nov 17, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 17, 2022

/test pre-main-serverless-integration-k3s

@anoipm
Copy link
Contributor Author

anoipm commented Nov 17, 2022

/test pull-function-controller-unit-test

@anoipm
Copy link
Contributor Author

anoipm commented Nov 17, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 17, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 18, 2022

/retest

@anoipm
Copy link
Contributor Author

anoipm commented Nov 18, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 18, 2022

/test pre-main-serverless-integration-k3s

@netlify
Copy link

netlify bot commented Nov 18, 2022

🥰 Documentation preview ready! 🥰

Name Link
🔨 Latest commit ee289e7
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/637f328400591b000858b8da
😎 Deploy Preview https://deploy-preview-16108--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anoipm
Copy link
Contributor Author

anoipm commented Nov 21, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 21, 2022

/test pre-main-serverless-integration-k3s

@anoipm
Copy link
Contributor Author

anoipm commented Nov 21, 2022

/test all

@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 22, 2022
@anoipm
Copy link
Contributor Author

anoipm commented Nov 22, 2022

/test all

@anoipm
Copy link
Contributor Author

anoipm commented Nov 22, 2022

/test pre-main-serverless-integration-k3s

@anoipm
Copy link
Contributor Author

anoipm commented Nov 22, 2022

/test pre-main-kyma-gke-external-registry

@anoipm anoipm marked this pull request as ready for review November 23, 2022 17:09
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 23, 2022
@anoipm
Copy link
Contributor Author

anoipm commented Nov 23, 2022

/retest

2 similar comments
@anoipm
Copy link
Contributor Author

anoipm commented Nov 23, 2022

/retest

@anoipm
Copy link
Contributor Author

anoipm commented Nov 24, 2022

/retest

anoipm and others added 2 commits November 24, 2022 09:59
…on.md

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
…on.md

Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 24, 2022
@anoipm
Copy link
Contributor Author

anoipm commented Nov 25, 2022

/retest

@kyma-bot
Copy link
Contributor

@anoipm: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-azure-alpha-prod ee289e7 link false /test pre-main-kyma-gardener-azure-alpha-prod
pre-main-kyma-gardener-azure-alpha-eval ee289e7 link false /test pre-main-kyma-gardener-azure-alpha-eval
pull-function-controller-lint c1a7a97 link false /test pull-function-controller-lint
pre-main-kyma-integration-k3d-runtime-agent c1a7a97 link false /test pre-main-kyma-integration-k3d-runtime-agent
pre-main-kyma-integration-k3d-app-conn-validator c1a7a97 link false /test pre-main-kyma-integration-k3d-app-conn-validator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit 4b9627c into kyma-project:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants