Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation webhook integration tests for eventmesh #16260

Merged

Conversation

raypinto
Copy link
Contributor

@raypinto raypinto commented Dec 5, 2022

Description

Changes proposed in this pull request:

  • Added env tests to make sure invalid subscriptions are not created with eventmesh backend

Related issue(s)

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2022
@raypinto raypinto force-pushed the em-validation-integration-tests branch from 0d8d8bd to 5dc2d07 Compare December 5, 2022 17:12
@raypinto raypinto linked an issue Dec 5, 2022 that may be closed by this pull request
@raypinto raypinto self-assigned this Dec 5, 2022
@mfaizanse mfaizanse self-assigned this Dec 6, 2022
@raypinto raypinto force-pushed the em-validation-integration-tests branch from 07a7329 to ab33e02 Compare December 7, 2022 10:34
@raypinto raypinto force-pushed the em-validation-integration-tests branch from 22f21a5 to 108e856 Compare December 7, 2022 15:55
@raypinto
Copy link
Contributor Author

raypinto commented Dec 7, 2022

/retest

Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 7, 2022
@kyma-bot kyma-bot merged commit ddec7a8 into kyma-project:main Dec 7, 2022
@raypinto raypinto deleted the em-validation-integration-tests branch December 7, 2022 17:10
@raypinto raypinto added the area/eventing Issues or PRs related to eventing label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests for Defaulting and Validating Webhook
4 participants