Rename Serverless internal registry initContainer #16266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelsayed
added
kind/bug
moelsayed
requested review from
m00g3n,
pPrecel,
dbadura,
kwiatekus,
Cortey and
anoipm
as code owners
kyma-bot
added
the
size/XS
dbadura
approved these changes
Dec 6, 2022
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the security-related changes made to the Serverless chart, extra functionality were added to the registry initContianer. So, it was renamed it to better reflect it's current function.
Normally this should be fine. However, since the Reconciler uses PATCH() by default to update resources, in this case, it will add a new initContainer to the deployment, not replace it. The end result is a deployment with 2 initContainers, one of them has old permission configuration which causes it to break.
To test this:
serverless-docker-registrypod inkyma-systemnamespace.Changes proposed in this pull request:
Related issue(s)
#15245
#16195
#16205