Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cleanup logic for jetstream v1alpha2 to clean slashes #16352

Merged
merged 3 commits into from Dec 13, 2022
Merged

Update cleanup logic for jetstream v1alpha2 to clean slashes #16352

merged 3 commits into from Dec 13, 2022

Conversation

raypinto
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Added slashes (front and back) to the list of disallowed characters for jetstream event source and type
  • This was lately updated by NATS here

Related issue(s)

@raypinto raypinto added the area/eventing Issues or PRs related to eventing label Dec 13, 2022
@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 13, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 13, 2022
@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 13, 2022 •
edited

@raypinto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-gcp-eventing-v1alpha2 a1038e3 link false /test pre-main-kyma-gardener-gcp-eventing-v1alpha2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit c9033ef into kyma-project:main Dec 13, 2022
@raypinto raypinto deleted the js-naming-backslashes branch December 13, 2022 15:15
k15r pushed a commit to k15r/kyma that referenced this pull request Dec 19, 2022
@raypinto @k15r
Update cleanup logic for jetstream v1alpha2 to clean slashes (kyma-pr…
3346947 
…oject#16352)

* Update cleanup logic for jetstream v1alpha2 to clean slashes

* Bump img
@mfaizanse mfaizanse removed their assignment Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfaizanse mfaizanse mfaizanse approved these changes

@k15r k15r Awaiting requested review from k15r

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@marcobebway marcobebway Awaiting requested review from marcobebway

@friedrichwilken friedrichwilken Awaiting requested review from friedrichwilken

@vpaskar vpaskar Awaiting requested review from vpaskar

@lilitgh lilitgh Awaiting requested review from lilitgh

@muralov muralov Awaiting requested review from muralov

Assignees

@raypinto raypinto

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raypinto @kyma-bot @mfaizanse