Update outdated docs #16407
Merged
Update outdated docs #16407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpaskar
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger and
nataliasitko
as code owners
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kyma-bot
added
the
size/S
mfaizanse
reviewed
Dec 20, 2022
| - `no space left on device` from the Eventing backend. | ||
| You observe the following behaviour in the Event Publisher Proxy(EPP): | ||
|
|
||
| - `507 Insufficient Storage` HTTP Status from EPP on publish request. |
There was a problem hiding this comment.
Suggested change
| - `507 Insufficient Storage` HTTP Status from EPP on publish request. | |
| - `507 Insufficient Storage` HTTP Status from Event Publisher Proxy on publish request. |
There was a problem hiding this comment.
Since I already introduce the EPP abbreviation above, I think it's valid to use EPP here.
There was a problem hiding this comment.
Well, its upto TWs to decide if its okay for public docs. :)
There was a problem hiding this comment.
Since the abbreviation was introduced before, it's ok to use it later in the doc :)
| You see one of the following messages: | ||
| - `507 Insufficient Storage` error from Event Publisher Proxy. | ||
| - `no space left on device` from the Eventing backend. | ||
| You observe the following behaviour in the Event Publisher Proxy(EPP): |
There was a problem hiding this comment.
Suggested change
| You observe the following behaviour in the Event Publisher Proxy(EPP): | |
| You observe the following message in the Event Publisher Proxy (EPP): |
There was a problem hiding this comment.
IMO let's keep it as is, since the one of the points underneath is not referring to message (the HTTP code). what do you think ?
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
vpaskar
force-pushed
the
update-outdated-docs
branch
from
14e2d03
to
5fc8a6a
Compare
vpaskar
force-pushed
the
update-outdated-docs
branch
from
5fc8a6a
to
51d56f7
Compare
grego952
reviewed
Dec 21, 2022
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
| - `no space left on device` from the Eventing backend. | ||
| You observe the following behaviour in the Event Publisher Proxy(EPP): | ||
|
|
||
| - `507 Insufficient Storage` HTTP Status from EPP on publish request. |
There was a problem hiding this comment.
Since the abbreviation was introduced before, it's ok to use it later in the doc :)
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
docs/04-operation-guides/troubleshooting/eventing/evnt-04-free-jetstream-storage.md
Outdated
Show resolved
Hide resolved
grego952
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update outdated troubleshooting guide, since our EPP has significant logic/logs changes.