Add registry cache garbage collection for serverless #16425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelsayed
requested review from
m00g3n,
pPrecel,
dbadura,
kwiatekus,
Cortey and
anoipm
as code owners
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kyma-bot
added
the
size/L
moelsayed
added
kind/feature
|
/test pull-function-controller-unit-test |
|
It's ok for me. I'm waiting for |
moelsayed
requested review from
mmitoraj,
NHingerl,
grego952,
IwonaLanger and
nataliasitko
as code owners
anoipm
previously approved these changes
Dec 22, 2022
moelsayed
added
the
do-not-merge/hold
grego952
reviewed
Dec 23, 2022
components/function-controller/design/internal_registry_garbage_collection.md
Outdated
Show resolved
Hide resolved
components/function-controller/design/internal_registry_garbage_collection.md
Outdated
Show resolved
Hide resolved
components/function-controller/design/internal_registry_garbage_collection.md
Outdated
Show resolved
Hide resolved
…e_collection.md Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
…e_collection.md Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
…e_collection.md Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
|
/retest |
1 similar comment
|
/retest |
grego952
approved these changes
Dec 23, 2022
moelsayed
removed
the
do-not-merge/hold
|
@moelsayed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
anoipm
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
16208