Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cloudevent client and factory #16460

Merged
merged 5 commits into from Dec 30, 2022
Merged

Add cloudevent client and factory #16460

merged 5 commits into from Dec 30, 2022

Conversation

nachtmaar
Copy link
Contributor

@nachtmaar nachtmaar commented Dec 29, 2022 •
edited

Description

Changes proposed in this pull request:

Screenshot 2022-12-29 at 15 05 21

Screenshot 2022-12-29 at 15 07 52

Screenshot 2022-12-29 at 15 06 11

Related issue(s)

See also #15705

@nachtmaar nachtmaar requested a review from a team as a code owner December 29, 2022 14:06
@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 2182d11
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63aeb5d8c21e0b0008aa60c9
😎 Deploy Preview https://deploy-preview-16460--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 29, 2022
@nachtmaar nachtmaar added the area/eventing Issues or PRs related to eventing label Dec 29, 2022
@friedrichwilken
Copy link
Contributor

Can you please explain the advantage over using plain old cloud events?

friedrichwilken
friedrichwilken previously approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2022
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 30, 2022
friedrichwilken
friedrichwilken approved these changes Dec 30, 2022
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2022
@nachtmaar
Copy link
Contributor Author

/retest-required

@friedrichwilken
Copy link
Contributor

/test pull-eventing-controller-unit-test

@kyma-bot kyma-bot merged commit c5817fd into kyma-project:main Dec 30, 2022
@nachtmaar nachtmaar self-assigned this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

Assignees

@nachtmaar nachtmaar

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nachtmaar @friedrichwilken @kyma-bot