Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Serverless registry-gc race condition #16475

Merged
merged 2 commits into from Dec 30, 2022
Merged

Conversation

moelsayed
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Refactor the tag delete logic to check the function status right before deleting the tag from the registry, to ensure it's not being updated.
  • ...
  • ...

Related issue(s)

#16208

@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 9732935
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63af0fc902e8e400082158a5
😎 Deploy Preview https://deploy-preview-16475--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2022
@moelsayed moelsayed added kind/bug Categorizes issue or PR as related to a bug. area/serverless Issues or PRs related to serverless and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 30, 2022
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 30, 2022
@kyma-bot
Copy link
Contributor

@moelsayed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-validate-image-existence 9732935 link false /test pre-main-kyma-validate-image-existence
pull-function-controller-lint 9732935 link false /test pull-function-controller-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anoipm anoipm self-assigned this Dec 30, 2022
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 30, 2022
@kyma-bot kyma-bot merged commit bcfe649 into kyma-project:main Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants