Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprof profiling to telemetry-operator #16485

Merged
merged 3 commits into from Jan 18, 2023

Conversation

chrkl
Copy link
Member

@chrkl chrkl commented Jan 3, 2023

Description

Changes proposed in this pull request:

  • Enable pprof profiling for telemetry-operator and make http endpoint configurable

Related issue(s)

@netlify
Copy link

netlify bot commented Jan 3, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit de61e27
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63c7f9d6247c080008d4fcb7
😎 Deploy Preview https://deploy-preview-16485--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 3, 2023
@chrkl
Copy link
Member Author

chrkl commented Jan 3, 2023

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 3, 2023
@chrkl
Copy link
Member Author

chrkl commented Jan 3, 2023

/retest

skhalash
skhalash previously approved these changes Jan 9, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 9, 2023
@chrkl chrkl force-pushed the telemetry-operator-profiling branch from 2889d44 to cc60e6f Compare January 16, 2023 15:48
@kyma-bot kyma-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2023
@chrkl
Copy link
Member Author

chrkl commented Jan 16, 2023

/unhold

@kyma-bot kyma-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@chrkl chrkl force-pushed the telemetry-operator-profiling branch from cc60e6f to 954cb6a Compare January 16, 2023 16:36
@chrkl
Copy link
Member Author

chrkl commented Jan 16, 2023

/retest

@a-thaler
Copy link
Contributor

What about testing?

@chrkl chrkl force-pushed the telemetry-operator-profiling branch from 954cb6a to de61e27 Compare January 18, 2023 13:53
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 18, 2023
@skhalash
Copy link
Contributor

/retest-required

@kyma-bot kyma-bot merged commit 8da6a48 into kyma-project:main Jan 18, 2023
@chrkl chrkl deleted the telemetry-operator-profiling branch January 18, 2023 14:28
@a-thaler a-thaler added the area/tracing Issues or PRs related to the tracing module (deprecated) label Jan 19, 2023
@a-thaler a-thaler added this to the 2.11 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing Issues or PRs related to the tracing module (deprecated) lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants