Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve application name parsing from request path #16510

Merged
merged 3 commits into from Jan 10, 2023
Merged

improve application name parsing from request path #16510

merged 3 commits into from Jan 10, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Jan 9, 2023

Description

Changes proposed in this pull request:

  • instead of parsing the entire path into a slice and then returning the first element, we just cleanup the string and cut off the first element.

Related issue(s)

@k15r k15r requested a review from a team as a code owner January 9, 2023 08:52
@k15r k15r added the area/eventing Issues or PRs related to eventing label Jan 9, 2023
@netlify
Copy link

netlify bot commented Jan 9, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a20bcc6
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63bd63cea7aa1a00096528b5
😎 Deploy Preview https://deploy-preview-16510--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2023
@friedrichwilken
Copy link
Contributor

/retest-required

friedrichwilken
friedrichwilken approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 10, 2023
@kyma-bot kyma-bot merged commit db52ad7 into kyma-project:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

Assignees

@k15r k15r

@friedrichwilken friedrichwilken

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k15r @friedrichwilken @kyma-bot