Fix otel collector restart #16517
Merged
Fix otel collector restart #16517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrkl
requested review from
a-thaler,
rakesh-garimella,
skhalash,
lindnerby,
dennis-ge,
lilitgh and
hisarbalik
as code owners
kyma-bot
added
the
size/XS
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest |
|
/hold |
kyma-bot
added
the
do-not-merge/hold
chrkl
force-pushed
the
fix-otel-collector-restart
branch
from
88548d5
to
3537cee
Compare
kyma-bot
added
size/S
skhalash
reviewed
Jan 10, 2023
Absolutely, planning to do that. |
|
/unhold |
kyma-bot
removed
the
do-not-merge/hold
skhalash
approved these changes
Jan 11, 2023
|
@chrkl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
chrkl
added a commit
to chrkl/kyma
that referenced
this pull request
Jan 11, 2023
* Fix otel collector restart * Bump telemetry-operator image * Enhance unittest for merging pod annotations
kyma-bot
pushed a commit
that referenced
this pull request
Jan 11, 2023
* Fix otel collector restart (#16517) * Fix otel collector restart * Bump telemetry-operator image * Enhance unittest for merging pod annotations * Bump telemetry-operator image
a-thaler
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restarting the telemetry-trace-collector pod after the TracePipeline has changed is triggered by adding a configuration hash annotation to the Pod template. The way how
kubectl.kubernetes.ioprefixed annotations were merged from an existing deployment caused this annotation to be dropped and the collector was never restarted due to a configuration change.This PR ensures fixes merging existing Pod annotations with the newly applied ones.
Changes proposed in this pull request:
Related issue(s)