Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug ability to the telemetry operator #16567

Merged
merged 17 commits into from Jan 19, 2023

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented Jan 16, 2023

Description

Changes proposed in this pull request:

  • The telemetry operator would look for override configmap at the start of reconciliation and would:
    • pause if the the pause flag is set in either logging or tracing config.
    • Change log level of controller runtime on fly.
  • To keep code simple a lazy implementation has been implemented, where one needs to trigger reconciliation after adding the configmap to the kyma-system namespace
  • Fast integration tests are implemented here

Related issue(s)

#16435

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2023
@netlify
Copy link

netlify bot commented Jan 16, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 15570a7
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63c96dfb7616b40008fa7da6
😎 Deploy Preview https://deploy-preview-16567--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rakesh-garimella rakesh-garimella linked an issue Jan 16, 2023 that may be closed by this pull request
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 16, 2023
@rakesh-garimella
Copy link
Contributor Author

/test all

@rakesh-garimella rakesh-garimella changed the title Ad debug ability to the telemetry operator Add debug ability to the telemetry operator Jan 16, 2023
@rakesh-garimella rakesh-garimella marked this pull request as ready for review January 17, 2023 14:33
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2023
@rakesh-garimella
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

@rakesh-garimella
Copy link
Contributor Author

/test pre-main-kyma-integration-k3d-telemetry

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 19, 2023
@kyma-bot
Copy link
Contributor

@rakesh-garimella: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-gardener-azure-alpha-prod 65cda49 link false /test pre-main-kyma-gardener-azure-alpha-prod
pre-main-kyma-gardener-azure-alpha-eval 65cda49 link false /test pre-main-kyma-gardener-azure-alpha-eval
pre-main-kyma-integration-k3d-telemetry-alpha 15570a7 link false /test pre-main-kyma-integration-k3d-telemetry-alpha

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit ad5e06c into kyma-project:main Jan 19, 2023
@a-thaler a-thaler added the area/tracing Issues or PRs related to the tracing module (deprecated) label Jan 19, 2023
@a-thaler a-thaler added this to the 2.11 milestone Jan 19, 2023
@rakesh-garimella rakesh-garimella deleted the add-pause-flag branch January 20, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tracing Issues or PRs related to the tracing module (deprecated) lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Runtime debuggability of telemetry-operator
4 participants