Add logging exporter to otel collector #16574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrkl
requested review from
a-thaler,
rakesh-garimella,
skhalash,
lindnerby,
dennis-ge,
lilitgh and
hisarbalik
as code owners
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kyma-bot
added
the
size/XS
|
/retest |
chrkl
force-pushed
the
otel-collector-logging
branch
from
807afaa
to
cccc9fe
Compare
kyma-bot
added
size/S
chrkl
force-pushed
the
otel-collector-logging
branch
from
ac9f75b
to
82205bc
Compare
|
@chrkl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Isn't a unit test missing at least? |
hisarbalik
approved these changes
Jan 18, 2023
a-thaler
added
the
area/tracing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#16435