Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always disable scraping for kube-state-metrics service #16792

Merged
merged 1 commit into from Feb 10, 2023
Merged

Always disable scraping for kube-state-metrics service #16792

merged 1 commit into from Feb 10, 2023

Conversation

skhalash
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix a problem with upgrading introduced in this PR. Since the reconciler does not remove annotations, we need to always set scraping to false

Related issue(s)
#11300

@skhalash skhalash requested a review from a team as a code owner February 10, 2023 12:03
@netlify
Copy link

netlify bot commented Feb 10, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit ffdffc3
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63e63287d576900008e131a7
😎 Deploy Preview https://deploy-preview-16792--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 10, 2023
@kyma-bot kyma-bot merged commit b66ee30 into kyma-project:main Feb 10, 2023
@mfaizanse mfaizanse mentioned this pull request Feb 10, 2023
Closed
@skhalash skhalash added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakesh-garimella rakesh-garimella rakesh-garimella approved these changes

Assignees

@rakesh-garimella rakesh-garimella

Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skhalash @rakesh-garimella @kyma-bot