Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert api gateway, istio, ory to annotation-based Prometheus scraping #16805

Merged

Conversation

skhalash
Copy link
Contributor

@skhalash skhalash commented Feb 13, 2023

Description

Changes proposed in this pull request:

  • Convert api gateway, istio, ory from service monitor-based to annotation-based Prometheus scraping

Related issue(s)
#11300

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2023
@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Feb 13, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit fe19b86
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/63eb6a76dc405700079aa12f
😎 Deploy Preview https://deploy-preview-16805--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2023
@skhalash skhalash marked this pull request as ready for review February 13, 2023 20:45
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2023
@skhalash
Copy link
Contributor Author

/retest

@skhalash
Copy link
Contributor Author

/test pre-main-kyma-gardener-azure-alpha-eval

@skhalash
Copy link
Contributor Author

/test pre-main-kyma-api-gateway-integration-k3d

@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 14, 2023

@skhalash: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-runtime-agent fe19b86 link false /test pre-main-kyma-integration-k3d-runtime-agent

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 14, 2023
@kyma-bot kyma-bot merged commit 68b5dfb into kyma-project:main Feb 15, 2023
@skhalash skhalash added the area/monitoring Issues or PRs related to the monitoring module (deprecated) label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring Issues or PRs related to the monitoring module (deprecated) lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants