Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude default request auto-instrumentation in python functions #16990

Merged
merged 1 commit into from Mar 8, 2023
Merged

Exclude default request auto-instrumentation in python functions #16990

merged 1 commit into from Mar 8, 2023

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Mar 3, 2023 •
edited

Description

Changes proposed in this pull request:

  • Do not auto-instrument request library by default as it causes error logs in case trace pipeline is missing
  • Use latest opentelemetry SDK version for python
  • configure sampling strategy

Related issue(s)
#16981

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@netlify
Copy link

netlify bot commented Mar 3, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit a28ab6b
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64085422f9910100084e322b
😎 Deploy Preview https://deploy-preview-16990--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 3, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kwiatekus kwiatekus added area/serverless Issues or PRs related to serverless area/telemetry Issues or PRs related to the telemetry module and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 3, 2023
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 3, 2023
@kwiatekus kwiatekus marked this pull request as ready for review March 8, 2023 07:53
@kwiatekus kwiatekus added this to the 2.12 milestone Mar 8, 2023
@kwiatekus @pPrecel
Upgrade OTEL SDK for Python runtime
a28ab6b 
Co-authored-by: Filip Strózik <filip.strozik@outlook.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 8, 2023
@kwiatekus kwiatekus changed the title Upgrade OTEL SDK for Python runtime Exclude default request auto-instrumentation in python functions Mar 8, 2023
@kyma-bot kyma-bot merged commit 446d093 into kyma-project:main Mar 8, 2023
4 checks passed
@kwiatekus kwiatekus mentioned this pull request Mar 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pPrecel pPrecel pPrecel approved these changes

@m00g3n m00g3n Awaiting requested review from m00g3n

@dbadura dbadura Awaiting requested review from dbadura

@Cortey Cortey Awaiting requested review from Cortey

@anoipm anoipm Awaiting requested review from anoipm

Assignees

@pPrecel pPrecel

Labels
area/serverless Issues or PRs related to serverless area/telemetry Issues or PRs related to the telemetry module lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kwiatekus @kyma-bot @pPrecel