use new telemetry priority class for fluent-bit #17546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
the
size/S
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rakesh-garimella
added
the
area/telemetry
|
/test pre-main-kyma-integration-k3d-telemetry |
chrkl
requested changes
May 24, 2023
resources/telemetry/values.yaml
Outdated
| @@ -18,6 +18,7 @@ global: | |||
| name: "fluent-bit" | |||
| version: "2.1.2-95ba1b02" | |||
| directory: "prod/tpi" | |||
| highPriorityClassName: "kyma-system-priority" | |||
| highPriorityClassName: "telemetry-priority-class-high" | |||
| PriorityClassName: "telemetry-priority-class" | |||
There was a problem hiding this comment.
Suggested change
| PriorityClassName: "telemetry-priority-class" | |
| priorityClassName: "telemetry-priority-class" |
There was a problem hiding this comment.
Let's move this out of the global section since it's specific for the telemetry component now. The templates should deal with both a global and a local value. Please double-check.
| kind: PriorityClass | ||
| metadata: | ||
| name: {{ .Values.global.highPriorityClassName }} | ||
| value: 3100000 |
There was a problem hiding this comment.
Adjust to the old priority values (for both classes)
|
/test pre-main-kyma-integration-k3d-telemetry |
|
/test pre-main-kyma-integration-k3d |
chrkl
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#17157