Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory limit for telemetry operator #17563

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

rakesh-garimella
Copy link
Contributor

@rakesh-garimella rakesh-garimella commented May 24, 2023

Description

Changes proposed in this pull request:

  • Telemetry operator is watching many resources in the cluster like secrets, configmaps etc. It can happen that when in a cluster there are many of these resources it would cause the cache to be big. Current limit 256 Mi would not be enough in such cases so increase it to 384Mi

  • Change is telemetry manager repo here
    Related issue(s)

kyma-project/telemetry-manager#197

@rakesh-garimella rakesh-garimella requested a review from a team as a code owner May 24, 2023 09:41
@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit eb08bc3
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6479ba688384890008766516
😎 Deploy Preview https://deploy-preview-17563--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rakesh-garimella rakesh-garimella added the area/telemetry Issues or PRs related to the telemetry module label May 24, 2023
@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 24, 2023
@@ -69,7 +69,7 @@ fluentbit:
resources:
limits:
cpu: 100m
memory: 256Mi
memory: 384Mi
requests:
cpu: 5m
memory: 20Mi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's increase the requests as well. It seems unrealistic that the operator runs with only 20Mi.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 5, 2023
@kyma-bot kyma-bot merged commit 2284eec into kyma-project:main Jun 5, 2023
14 checks passed
@a-thaler a-thaler added this to the 2.15 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/telemetry Issues or PRs related to the telemetry module lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants