Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes in Quick Install docs #17916

Merged
merged 2 commits into from Aug 1, 2023
Merged

Small fixes in Quick Install docs #17916

merged 2 commits into from Aug 1, 2023

Conversation

grego952
Copy link
Contributor

@grego952 grego952 commented Aug 1, 2023

Description

Changes proposed in this pull request:

  • Small fixes in Deploy and Expose a Function and Trigger a workload with an event

@grego952 grego952 requested a review from a team as a code owner August 1, 2023 13:08
@netlify
Copy link

netlify bot commented Aug 1, 2023 •
edited

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 73b3c23
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64c90864e115100008d068fe
😎 Deploy Preview https://deploy-preview-17916--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 1, 2023
@grego952 @nataliasitko
Apply suggestions from code review
73b3c23 
Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 1, 2023
@kyma-bot kyma-bot merged commit 774d72e into kyma-project:main Aug 1, 2023
10 of 11 checks passed
kyma-bot pushed a commit that referenced this pull request Aug 2, 2023
@grego952 @nataliasitko
Small fixes in Quick Install docs (#17916) (#17922)
e2f8149 
* Small fixes in Quick Install docs

* Apply suggestions from code review



---------

Co-authored-by: Natalia Sitko <80401180+nataliasitko@users.noreply.github.com>
@grego952 grego952 added the area/documentation Issues or PRs related to documentation label Aug 24, 2023
@grego952 grego952 deleted the quick-install-fix branch September 5, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliasitko nataliasitko nataliasitko approved these changes

Assignees

@nataliasitko nataliasitko

Labels
area/documentation Issues or PRs related to documentation lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grego952 @nataliasitko @kyma-bot