Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated JaegerServiceEndpoint #17942

Merged

Conversation

kwiatekus
Copy link
Contributor

Description

Changes proposed in this pull request:

  • remove unused JaegerServiceEndpoint from function-controller and runtimes

Related issue(s)
kyma-project/serverless#168

@kwiatekus kwiatekus added area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Aug 7, 2023
@kwiatekus kwiatekus requested a review from a team as a code owner August 7, 2023 13:17
@netlify
Copy link

netlify bot commented Aug 7, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 418d185
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64d2027f950cfb0008591d2e
😎 Deploy Preview https://deploy-preview-17942--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2023
@dbadura dbadura self-assigned this Aug 8, 2023
Copy link
Contributor

@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump image

@dbadura dbadura assigned kwiatekus and unassigned dbadura Aug 8, 2023
@kwiatekus kwiatekus force-pushed the cleanup-deprecated-jaeger-endpoint branch from 1545bae to 0e1dd3f Compare August 8, 2023 08:51
@kwiatekus
Copy link
Contributor Author

Bump image

@dbadura done

@kwiatekus
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 8, 2023
@dbadura
Copy link
Contributor

dbadura commented Aug 8, 2023

/retest

@kyma-bot kyma-bot merged commit 8c3beb2 into kyma-project:main Aug 8, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants