Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #18016

Merged
merged 32 commits into from Sep 6, 2023
Merged

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Aug 22, 2023

Description

client -> gateway -> service
       ^A         ^B
client <- gateway <- service
       ^C         ^D

We already had logging of A and C (in some form).
Logging of B and D would be helpful.

Changes proposed in this pull request:

  • Add logging for B
  • Change (and clean up) logging system

Related issue(s)

#17905
#17265

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 2941e2e
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64f81a2638ad6a0008875646
😎 Deploy Preview https://deploy-preview-18016--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2023
@VOID404 VOID404 linked an issue Aug 22, 2023 that may be closed by this pull request
5 tasks
@netlify
Copy link

netlify bot commented Aug 22, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2941e2e

@VOID404 VOID404 force-pushed the central-app-gateway-logging branch 2 times, most recently from 211c6e3 to 16333fd Compare August 22, 2023 15:22
@VOID404 VOID404 marked this pull request as ready for review August 22, 2023 15:22
@VOID404 VOID404 requested a review from a team as a code owner August 22, 2023 15:22
@VOID404
Copy link
Contributor Author

VOID404 commented Aug 22, 2023

Example req:

GET http://localhost:8080/httpbin/raw/status/500
Accept: application/json

response:

<!-- GET http://localhost:8080/httpbin/raw/status/500 -->
<!-- HTTP/1.1 502 Bad Gateway -->
<!-- Access-Control-Allow-Credentials: true -->
<!-- Access-Control-Allow-Origin: * -->
<!-- Content-Length: 0 -->
<!-- Content-Type: text/html; charset=utf-8 -->
<!-- Date: Mon, 21 Aug 2023 16:35:03 GMT -->
<!-- Server: gunicorn/19.9.0 -->
<!-- Target-System-Status: 500 -->
<!-- Request duration: 0.089449s -->

logs:

{"level":"debug","ts":1692635703.967423,"caller":"proxy/reverseproxy.go:133","msg":"GET localhost:3000 /status/500 HTTP/1.1","requestID":null,"method":"GET","host":"localhost:3000","url":"/status/500","proto":"HTTP/1.1","code":500,"contentLength":0,"kind":"response"}
{"level":"debug","ts":1692635703.967733,"caller":"httptools/logging.go:71","msg":"GET localhost:8080 status/500 HTTP/1.1","label":"Internal handler: ","duration":80,"code":502,"requestID":"bc5c5573-7012-455a-98b2-3f5d9372d24b","method":"GET","host":"localhost:8080","url":"status/500","proto":"HTTP/1.1","kind":"request"}

There is a problem with requestID, but this already seems way more helpful

@kyma-project kyma-project deleted a comment from kyma-bot Aug 22, 2023
@VOID404 VOID404 force-pushed the central-app-gateway-logging branch from 16333fd to cd20612 Compare August 22, 2023 15:32
@VOID404 VOID404 force-pushed the central-app-gateway-logging branch from cd20612 to 63e669d Compare August 22, 2023 15:35
@VOID404 VOID404 mentioned this pull request Aug 23, 2023
@VOID404 VOID404 requested a review from mvshao September 1, 2023 13:04
mvshao
mvshao previously approved these changes Sep 5, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 5, 2023
@VOID404 VOID404 changed the title [WIP] Improve logging Improve logging Sep 5, 2023
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2023
Co-authored-by: Grzegorz Karaluch <grzegorz.karaluch@sap.com>
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 6, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 6, 2023

@VOID404: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 2941e2e link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 6, 2023
@kyma-bot kyma-bot merged commit 4be474c into kyma-project:main Sep 6, 2023
23 of 24 checks passed
@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label Sep 20, 2023
@Disper Disper added this to the 2.19 milestone Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logs of central-application-gateway
5 participants