Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature flag to disable provisioning of NATS as part of eventing #18041

Merged
merged 3 commits into from Aug 29, 2023

Conversation

mfaizanse
Copy link
Member

@mfaizanse mfaizanse commented Aug 24, 2023

Description

Changes proposed in this pull request:

  • Added feature flag to disable provisioning of NATS as part of eventing.
  • kyma deploy --source=PR-18041 --profile=production --value eventing.global.jetstream.enabled=false

Related issue(s)

@mfaizanse mfaizanse requested a review from a team as a code owner August 24, 2023 13:37
@mfaizanse mfaizanse requested a review from muralov August 24, 2023 13:37
@netlify
Copy link

netlify bot commented Aug 24, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit c90038f

@mfaizanse mfaizanse added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2023
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 24, 2023
@mfaizanse mfaizanse linked an issue Aug 24, 2023 that may be closed by this pull request
5 tasks
@netlify
Copy link

netlify bot commented Aug 24, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit c90038f
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64ec694faa074e0008695f5d
😎 Deploy Preview https://deploy-preview-18041--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mfaizanse
Copy link
Member Author

/test pre-main-kyma-gardener-gcp-eventing-upgrade

@mfaizanse
Copy link
Member Author

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 29, 2023
@mfaizanse mfaizanse removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@kyma-bot kyma-bot merged commit 1b014d1 into kyma-project:main Aug 29, 2023
18 checks passed
mfaizanse added a commit to mfaizanse/kyma that referenced this pull request Aug 29, 2023
kyma-project#18041)

* Added feature flag to disable provisioning of NATS as part of eventing

* image bump
kyma-bot pushed a commit that referenced this pull request Aug 29, 2023
#18075)

* Added feature flag to disable provisioning of NATS as part of eventing (#18041)

* Added feature flag to disable provisioning of NATS as part of eventing

* image bump

* undo image bump
@friedrichwilken friedrichwilken added the area/eventing Issues or PRs related to eventing label Sep 21, 2023
@mfaizanse mfaizanse deleted the nats_feature_flag branch September 25, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update eventing to not deploy nats-cluster
4 participants