Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement code rewriting for conn-validator #18157

Merged
merged 5 commits into from Sep 13, 2023

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Sep 13, 2023

Description

Changes proposed in this pull request:

same as #18007 but for validator

@VOID404 VOID404 requested a review from a team as a code owner September 13, 2023 06:58
@netlify
Copy link

netlify bot commented Sep 13, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit b751706

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit b751706
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65017f415cb0820008fbce4c
😎 Deploy Preview https://deploy-preview-18157--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2023
@kyma-bot
Copy link
Contributor

@VOID404: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-central-application-connectivity-validator-unit-test b751706 link false /test pull-central-application-connectivity-validator-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 13, 2023
@m00g3n m00g3n added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 13, 2023
@kyma-bot kyma-bot merged commit 305cc7a into kyma-project:main Sep 13, 2023
12 of 13 checks passed
@Disper Disper removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
@Disper Disper added this to the 2.19 milestone Sep 22, 2023
@Disper Disper added the area/application-connector Issues or PRs related to application connectivity label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/application-connector Issues or PRs related to application connectivity lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants