Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove replicas validation #18163

Merged
merged 1 commit into from Sep 14, 2023

Conversation

pPrecel
Copy link
Contributor

@pPrecel pPrecel commented Sep 13, 2023

Description

Changes proposed in this pull request:

  • Remove validation of the spec.replicas and the spec.scaleConfig fields

Related issue(s)

kyma-project/serverless#251

@pPrecel pPrecel requested a review from a team as a code owner September 13, 2023 15:03
@netlify
Copy link

netlify bot commented Sep 13, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4f5d22d

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 4f5d22d
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6502ca87b0af67000774c723
😎 Deploy Preview https://deploy-preview-18163--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 13, 2023
@pPrecel
Copy link
Contributor Author

pPrecel commented Sep 13, 2023

/test all

@pPrecel
Copy link
Contributor Author

pPrecel commented Sep 14, 2023

should be merged after
#18114

@pPrecel pPrecel force-pushed the remove-replicas-validation branch 3 times, most recently from c0c9973 to 6935254 Compare September 14, 2023 08:37
@dbadura dbadura self-assigned this Sep 14, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 14, 2023
@kyma-bot kyma-bot merged commit 7189552 into kyma-project:main Sep 14, 2023
21 checks passed
@pPrecel pPrecel added the area/serverless Issues or PRs related to serverless label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serverless Issues or PRs related to serverless lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants