Add "virtualservices.networking.istio.io" to kyma-admin and kyma-view API groups #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 4, 2018 12:19
This reverts commit 8590194.
tomekpapiernik
added
kind/bug
piotrmsc
approved these changes
Dec 4, 2018
sjanota
reviewed
Dec 4, 2018
| @@ -30,7 +30,7 @@ metadata: | |||
| annotations: | |||
| "helm.sh/hook-weight": "0" | |||
| rules: | |||
| - apiGroups: ["", "apps", "authentication.kyma-project.io", "extensions", "gateway.kyma-project.io", "kubeless.io", "rbac.authorization.k8s.io", "applicationconnector.kyma-project.io", "servicecatalog.k8s.io", "servicecatalog.kyma.cx", "settings.k8s.io", "kyma.cx", "authentication.istio.io", "config.istio.io", "eventing.kyma.cx", "ui.kyma.cx", "ui.kyma-project.io", "metrics.k8s.io"] | |||
| - apiGroups: ["", "apps", "authentication.kyma-project.io", "extensions", "gateway.kyma-project.io", "kubeless.io", "rbac.authorization.k8s.io", "applicationconnector.kyma-project.io", "servicecatalog.k8s.io", "servicecatalog.kyma.cx", "settings.k8s.io", "kyma.cx", "authentication.istio.io", "config.istio.io", "eventing.kyma.cx", "ui.kyma.cx", "ui.kyma-project.io", "metrics.k8s.io", "virtualservices.networking.istio.io"] | |||
There was a problem hiding this comment.
virtualservices is resource kind. networking.istio.io should be sufficient
There was a problem hiding this comment.
hmm, I like the idea of increasing permissions to the whole networinkg.istio.io group
tomekpapiernik
pushed a commit
to tomekpapiernik/kyma
that referenced
this pull request
Dec 6, 2018
venturasr
pushed a commit
to venturasr/kyma
that referenced
this pull request
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #1889