Move cluster overrides directly to Helm charts, split installation artifacts

[mszostok]

Description

Changes proposed in this pull request:

• Move cluster overrides directly to Helm charts, split installation artifacts. NOTE:
  • acceptanceTest.application.disabled: "true" was removed because it was not used by any chart
  • the etcd-stateful.replicaCount: "3" was applied as a global overrides for all chart. In this PR it's fixed and only service-catalog chart has this definition

Related issue(s)

• We need to make the upgrade process between the Kyma releases independent from client installation overrides #2353

[crabtree]

What about changes in PowerShell scripts? If we no longer bother with aligning them then we should remove information about installing kyma on Windows from our readme.

[mszostok]

What about changes in PowerShell scripts?

Scope of this task: Move cluster overrides directly to Helm charts

I did that. I also modified all place where changes were required. In PowerShell scripts we do not have support for KNATIVE so I didnt modify there anything cause those scripts does not contains any logic for it.

You question is valid but not for this thask. IMO you should escalate and maybe report to some SIG :)

vacations, discussed with PM

[crabtree]

@mszostok In the run.ps1 script there is some support for knative. I'm not sure how and if it works, but in my opinion, we should keep bash script and ps scripts consistent.

[mszostok]

@crabtree In run.ps1 there is support same as we have in run.sh.
But in installer.ps1 there is lack of this feature. If some knative developer wants to fix that, then he/she can add comment and I will do that by the way.

(..) but in my opinion, we should keep bash script and ps scripts consistent.

I agree, but this is knative developers responsibility.

my pr scope: Move cluster overrides directly to Helm charts
not: ensure Knative support both for Windows and Unix

:)

[marcobebway]

I have two very minor comments, other than that LGTM.

[kyma-bot]

@mszostok: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pre-master-kyma-gke-upgrade	589a431	link	/test pre-master-kyma-gke-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.