Add ServiceMonitor CRD to cluster essentials #2429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derberg
requested review from
adamwalach,
aszecowka,
crabtree,
Demonsthere,
jakkab,
jasiu001,
kfurgol,
kubadz,
mszostok,
mwieczorek,
piotrmiskiewicz,
piotrmsc,
PK85,
polskikiel,
sjanota,
strekm and
Tomasz-Smelcerz-SAP
as code owners
derberg
added
WIP
kind/feature
joek
approved these changes
Jan 25, 2019
PK85
requested changes
Jan 25, 2019
| @@ -16,8 +16,6 @@ spec: | |||
| namespace: "istio-system" # KNative comes with namespaces hardcoded so this one is only for installer | |||
| - name: "istio-kyma-patch" | |||
| namespace: "istio-system" | |||
| - name: "prometheus-operator" | |||
There was a problem hiding this comment.
Contact @klaudiagrz and extend documentation about how to enable monitoring,
PK85
approved these changes
Jan 25, 2019
|
/test pre-master-kyma-gke-integration |
derberg
requested review from
kwiatekus,
lilitgh,
lszymik,
Maladie,
maxmarkus,
pbochynski,
pekura,
rakesh-garimella,
sayanh,
Szymongib,
venturasr and
y-kkamil
as code owners
|
I don't like that prometheus-operator stays a separate module, should be merged with monitoring module. After talking to @joek it seems to not be a trivial taks to merge them, I will create a follow-up for that. |
a-thaler
approved these changes
Jan 28, 2019
klaudiagrz
reviewed
Jan 28, 2019
Co-Authored-By: derberg <derberg@wp.pl>
klaudiagrz
approved these changes
Jan 28, 2019
|
@derberg: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This would be a temporary solution to enable local development without heavy Prometheus. Long term I will work with @PK85 on proposal how to do modularization the same way in all charts instead of solving modularization challenges case by case.
Changes proposed in this pull request:
Kyma resource consumption on minikube without Prometheus:
Related issue(s)
Resolves #1840