Don't ignore errors in UI API Layer #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgorgol
added
kind/bug
tgorgol
requested review from
adamwalach,
aerfio,
akucharska,
aszecowka,
jasiu001,
magicmatatjahu,
hudymi,
mjasinski5,
mszostok,
piotrmiskiewicz,
PK85,
pkosiec and
polskikiel
as code owners
pkosiec
reviewed
Feb 6, 2019
| fmt.Fprintln(w, data) | ||
| _, err := fmt.Fprintln(w, data) | ||
| if err != nil { | ||
| glog.Warningf("Unable to write response body. Cause: %v", err) |
| body.Close() | ||
| err := iosafety.DrainReader(body) | ||
| if err != nil { | ||
| glog.Warningf("Unable to drain body reader. Cause: %v", err) |
There was a problem hiding this comment.
maybe it would be good to return these errors. If this is not an option, log them with error level
| flag.Set("stderrthreshold", "INFO") | ||
| err := flag.Set("stderrthreshold", "INFO") | ||
| if err != nil { | ||
| glog.Error(errors.Wrap(err, "while parsing flags")) |
There was a problem hiding this comment.
Please consider glog.Fatal- but it's totally up to you
There was a problem hiding this comment.
I decided that the error occurring during setting that flag wasn't critical because it wasn't really related to parsing user provided flags and that logging the error without exiting the application would suffice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#2113 #2587