Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the event source-id and the event-type-version in the knative channel name #2817

Merged

Conversation

marcobebway
Copy link
Contributor

Description

  • include the event source-id and the event-type-version in the knative channel name
  • update the tests

Related issue(s)
#2797

@marcobebway marcobebway added kind/bug Categorizes issue or PR as related to a bug. WIP priority/critical Priority indication area/eventing Issues or PRs related to eventing labels Feb 20, 2019
@marcobebway marcobebway added this to the Sprint_Malones_17 milestone Feb 20, 2019
@marcobebway marcobebway self-assigned this Feb 20, 2019
@marcobebway marcobebway requested a review from a user February 20, 2019 14:24
@marcobebway marcobebway force-pushed the encode-knative-channel-name branch 5 times, most recently from c60e971 to 73dee79 Compare February 20, 2019 16:30
@marcobebway marcobebway removed the WIP label Feb 20, 2019
@marcobebway marcobebway force-pushed the encode-knative-channel-name branch 2 times, most recently from 11f8bb2 to 789b99b Compare February 21, 2019 14:41
@marcobebway marcobebway merged commit 7e6b2c9 into kyma-project:master Feb 21, 2019
grischperl pushed a commit to grischperl/kyma that referenced this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing kind/bug Categorizes issue or PR as related to a bug. priority/critical Priority indication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant