Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hostNetwork setting with hostAliases for ui-acceptance test minikube executions #2909

Merged

Conversation

kwiatekus
Copy link
Contributor

@kwiatekus kwiatekus commented Feb 28, 2019

Description

Changes proposed in this pull request:

  • Applied hostAliases instead of hostNetwork configuration for ui test pod when executed on minikube

Related issue(s)
#2705

@kwiatekus kwiatekus added kind/bug Categorizes issue or PR as related to a bug. area/busola Related to all activities around the Busola UI and all its views labels Feb 28, 2019
@kwiatekus kwiatekus changed the title Disable hostNetwork for ui-acceptance test for cluster executions Replace hostNetwork setting with hostAliases for ui-acceptance test minikube executions Feb 28, 2019
@kwiatekus kwiatekus marked this pull request as ready for review February 28, 2019 15:03
installation/scripts/installer.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@strekm strekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-6 :D

Copy link
Contributor

@mszostok mszostok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwiatekus kwiatekus merged commit 183d6f8 into kyma-project:master Mar 1, 2019
sjanota pushed a commit to sjanota/kyma that referenced this pull request Mar 1, 2019
…inikube executions (kyma-project#2909)

Apply hostAliases for ui-acceptance test minikube executions
Demonsthere pushed a commit to Demonsthere/kyma that referenced this pull request Mar 7, 2019
…inikube executions (kyma-project#2909)

Apply hostAliases for ui-acceptance test minikube executions
@kwiatekus kwiatekus deleted the disable-hostNetwork-on-cluster branch May 10, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/busola Related to all activities around the Busola UI and all its views kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants