-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hostNetwork setting with hostAliases for ui-acceptance test minikube executions #2909
Merged
kwiatekus
merged 8 commits into
kyma-project:master
from
kwiatekus:disable-hostNetwork-on-cluster
Mar 1, 2019
Merged
Replace hostNetwork setting with hostAliases for ui-acceptance test minikube executions #2909
kwiatekus
merged 8 commits into
kyma-project:master
from
kwiatekus:disable-hostNetwork-on-cluster
Mar 1, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strekm
requested changes
Mar 1, 2019
strekm
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-6 :D
mszostok
approved these changes
Mar 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pekura
approved these changes
Mar 1, 2019
sjanota
pushed a commit
to sjanota/kyma
that referenced
this pull request
Mar 1, 2019
…inikube executions (kyma-project#2909) Apply hostAliases for ui-acceptance test minikube executions
Demonsthere
pushed a commit
to Demonsthere/kyma
that referenced
this pull request
Mar 7, 2019
…inikube executions (kyma-project#2909) Apply hostAliases for ui-acceptance test minikube executions
This was referenced Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/busola
Related to all activities around the Busola UI and all its views
kind/bug
Categorizes issue or PR as related to a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
hostAliases
instead ofhostNetwork
configuration for ui test pod when executed on minikubeRelated issue(s)
#2705