Add openApiSpec and odataSpec field for CSC and SC in ui-api-layer #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
added
kind/feature
magicmatatjahu
requested review from
adamwalach,
aerfio,
akucharska,
aszecowka,
jasiu001,
hudymi,
mjasinski5,
mszostok,
piotrmiskiewicz,
PK85,
pkosiec,
polskikiel and
tgorgol
as code owners
magicmatatjahu
force-pushed
the
openapi-odata-spec
branch
from
b9c8084
to
0a0bf9b
Compare
pkosiec
reviewed
Mar 5, 2019
| @@ -1,5 +1,4 @@ | |||
| // Code generated by mockery v1.0.0. DO NOT EDIT. | |||
There was a problem hiding this comment.
Please reset these formatting changes in mocks
| type handler func(filename string) (interface{}, bool, error) | ||
| const ( | ||
| ApiSpecField = "apiSpec" | ||
| OpenApiSpecField = "openApiSpec" |
There was a problem hiding this comment.
Rename OpenApi to OpenAPI everywhere
| AsyncApiSpec(id string) (*AsyncApiSpec, bool, error) | ||
| Content(id string) (*Content, bool, error) | ||
| NotificationChannel(stop <-chan struct{}) <-chan notification | ||
| } | ||
|
|
||
| type handler func(filename string) (interface{}, bool, error) | ||
| const ( | ||
| ApiSpecField = "apiSpec" |
| @@ -60,6 +64,70 @@ func (o *ApiSpec) UnmarshalJSON(jsonData []byte) error { | |||
| return nil | |||
| } | |||
|
|
|||
| type OpenApiSpec struct { | |||
pkosiec
approved these changes
Mar 5, 2019
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
openApiSpecandodataSpecfield for CSC and SC in ui-api-layerdeprecatedlabel forapiSpecfield.Related Pr(s)
#2967
Related issue(s)
Resolves https://github.com/kyma-project/console/issues/561