Make knative default #3403
Make knative default #3403
Conversation
|
/test pre-master-kyma-integration |
abbi-gaurav
requested review from
a-thaler,
adamwalach,
aszecowka,
crabtree,
Demonsthere,
jakkab,
jasiu001,
joek,
k15r,
kfurgol,
kubadz,
lilitgh,
marcobebway,
montaro,
mszostok,
mwieczorek,
piotrmiskiewicz,
piotrmsc,
PK85 and
polskikiel
as code owners
abbi-gaurav
requested review from
rakesh-garimella,
sayanh,
sjanota and
strekm
as code owners
abbi-gaurav
requested review from
kazydek,
klaudiagrz,
mmitoraj and
tomekpapiernik
as code owners
|
/test pre-master-kyma-gke-upgrade |
There was a problem hiding this comment.
LGTM from the ServicCatalog perspective
You removed
-memory 10240 -disk_size 30g
and right now Kyma will have enabled knative by default. What about the memory and disk size? our installation will not need higher resource definition?
Should you consider to add flag for disabling knative? Installing it for local development sometimes could be not needed (plus I do not want to allocate higher memory and disk size if I'm not using such functionality)
|
/test pre-master-kyma-integration |
- Add DEFAULT_CLUSTER_ID for nats controller and dispatcher - Disable client authentication in nats streaming
- Pending: the old publish apps are not deleted
- all non-knative charts and deployments are getting delete
Co-Authored-By: abbi-gaurav <abbi.gaurav@gmail.com>
abbi-gaurav
force-pushed
the
make-knative-default
branch
from
586b87a
to
53e6862
Compare
@mszostok, going further, kyma eventing will only be built on top of knative eventing. So we do not have the option to optionally enable or disable knative. I removed this after verifying that the current resource allocation was working fine. The reason for |
| if ($SKIP_MINIKUBE_START -eq $false) { | ||
| Invoke-Expression -Command "${SCRIPTS_DIR}\minikube.ps1 -vm_driver ${VM_DRIVER} -domain ${DOMAIN} ${MINIKUBE_EXTRA_ARGS}" | ||
| Invoke-Expression -Command "${SCRIPTS_DIR}\minikube.ps1 -vm_driver ${VM_DRIVER} -domain ${DOMAIN} |
There was a problem hiding this comment.
I will create a second PR for this. To unblock other tasks, I will merge it once the tests succeed.
abbi-gaurav
dismissed
ghost
’s stale review
as discussed, it will be added in next pr
Description
Related issue(s)
See also #3017