use ko for function-controller development deployment #5613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k15r
requested review from
devguyio,
anishj0shi,
antoineco,
lilitgh,
marcobebway,
montaro and
nachtmaar
as code owners
k15r
requested review from
rakesh-garimella,
sayanh and
venturasr
as code owners
antoineco
reviewed
Sep 11, 2019
antoineco
reviewed
Sep 12, 2019
k15r
requested review from
alexandra-simeonova,
bszwarc,
kazydek,
klaudiagrz,
majakurcius,
mmitoraj and
tomekpapiernik
as code owners
done |
rakesh-garimella
approved these changes
Sep 17, 2019
antoineco
suggested changes
Sep 17, 2019
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
Co-Authored-By: Barbara Szwarc <barbara.m.szwarc@gmail.com>
antoineco
suggested changes
Sep 18, 2019
| ```bash | ||
| make deploy | ||
| ``` | ||
| >**NOTE:** Make sure the **KO_DOCKER_REPO** environment variable points to a valid docker repository. |
There was a problem hiding this comment.
Instead of that isolated note, I think it would be helpful to have the env var described together with the other env vars at the top.
| @@ -102,18 +113,22 @@ Follow these steps to prepare the environment you will use to deploy the Control | |||
|
|
|||
| ### Deploy the controller | |||
|
|
|||
| 1. Use the `make` targets to build the Function Controller image, tag it to the value of the **IMG** environment variable, and push it to the remote container registry. | |||
There was a problem hiding this comment.
IMG can also be removed in the intro.
antoineco
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
after switching to ko i cannot reproduce the broken webhook anymore
Changes proposed in this pull request:
Related issue(s)