Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for rafter domain in console-backend-service #6474

Conversation

magicmatatjahu
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Add integration tests for rafter domain in console-backend-service
  • Remove tests for cms domain
  • Update tests for service-catalog domain

Related issue(s)
#6472

@magicmatatjahu magicmatatjahu added kind/feature Categorizes issue or PR as related to a new feature. area/core-and-supporting Issues or PRs related to core and supporting labels Nov 30, 2019
@hudymi
Copy link
Contributor

hudymi commented Dec 5, 2019

For me, it looks OK, but I would like to know what was the reason for disabling these tests because I think we can improve them in this PR.

@kwiatekus @akucharska ?

@magicmatatjahu magicmatatjahu force-pushed the rafter-console-backend-service-e2e-tests branch from c72a3b0 to dc04727 Compare December 6, 2019 18:48
@netlify
Copy link

netlify bot commented Dec 6, 2019

🥰 Documentation preview ready! 🥰

Built with commit dc04727

https://deploy-preview-6474--kyma-project-docs-preview.netlify.com

@magicmatatjahu magicmatatjahu force-pushed the rafter-console-backend-service-e2e-tests branch 2 times, most recently from d27d037 to bca2c1f Compare December 10, 2019 12:26
@magicmatatjahu
Copy link
Contributor Author

/test pre-kyma-components-uaa-activator

@kyma-bot
Copy link
Contributor

@magicmatatjahu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pre-kyma-components-uaa-activator bca2c1f link /test pre-kyma-components-uaa-activator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@magicmatatjahu magicmatatjahu force-pushed the rafter-console-backend-service-e2e-tests branch from bca2c1f to 17c47d6 Compare December 17, 2019 13:49
Copy link
Contributor

@dariadomagala-sap dariadomagala-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@magicmatatjahu magicmatatjahu merged commit 80777a4 into kyma-project:master Dec 18, 2019
@magicmatatjahu magicmatatjahu deleted the rafter-console-backend-service-e2e-tests branch December 18, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core-and-supporting Issues or PRs related to core and supporting kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants