Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging diagram and description #6486

Merged
merged 5 commits into from Dec 4, 2019

Conversation

bszwarc
Copy link
Contributor

@bszwarc bszwarc commented Dec 2, 2019

Description

Changes proposed in this pull request:

  • Improved logging diagram
  • Added a description for the diagram
  • Improved logging overview

Related issue(s)
See also #6074

@bszwarc bszwarc added area/documentation Issues or PRs related to documentation area/logging Issues or PRs related to the logging module (deprecated) labels Dec 2, 2019
@bszwarc bszwarc added this to the Sprint_Huskies_15 milestone Dec 2, 2019
@bszwarc bszwarc self-assigned this Dec 2, 2019
@netlify
Copy link

netlify bot commented Dec 2, 2019

🥰 Documentation preview ready! 🥰

Built with commit cc0da12

https://deploy-preview-6486--kyma-project-docs-preview.netlify.com

@bszwarc bszwarc added WIP and removed WIP labels Dec 2, 2019
Copy link
Contributor

@mmitoraj mmitoraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. I added some minor comments :) I would also try to avoid such expression as "currently" (line 6) or "at the moment" (line 8) as they are difficult to maintain but if they are needed and should stay then it's fine for me.

docs/logging/02-01-logging.md Outdated Show resolved Hide resolved
docs/logging/02-01-logging.md Outdated Show resolved Hide resolved
docs/logging/02-01-logging.md Outdated Show resolved Hide resolved
@bszwarc bszwarc merged commit ae978ad into kyma-project:master Dec 4, 2019
@bszwarc bszwarc deleted the 6074-logging branch December 4, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation area/logging Issues or PRs related to the logging module (deprecated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants