Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event-sources: Disable Knative scale to 0 #6619

Merged
merged 2 commits into from Dec 30, 2019
Merged

event-sources: Disable Knative scale to 0 #6619

merged 2 commits into from Dec 30, 2019

Conversation

antoineco
Copy link
Contributor

@antoineco antoineco commented Dec 13, 2019 •
edited

Description

Changes proposed in this pull request:

  • Set the autoscaling.knative.dev/minScale: "1" annotation on all Knative Services managed by the event-source controller.

Related issue(s)

#5352

@antoineco antoineco requested a review from a user December 13, 2019 14:17
@antoineco antoineco self-assigned this Dec 13, 2019
@antoineco antoineco added the area/eventing Issues or PRs related to eventing label Dec 13, 2019
@antoineco antoineco added this to the Sprint_SkydivingTunas_8 milestone Dec 13, 2019
@antoineco
Copy link
Contributor Author

antoineco commented Dec 13, 2019 •
edited

Closing. Will open a new PR to disable it globally.

@antoineco antoineco closed this Dec 13, 2019
@antoineco antoineco deleted the disable-knative-scaleto0 branch December 13, 2019 16:28
@antoineco antoineco mentioned this pull request Dec 13, 2019
Closed
@antoineco antoineco mentioned this pull request Dec 30, 2019
Closed
@antoineco antoineco restored the disable-knative-scaleto0 branch December 30, 2019 10:49
@antoineco antoineco reopened this Dec 30, 2019
@antoineco
Copy link
Contributor Author

Reopened. We decided this solution was the best compromise for now.

devguyio
devguyio approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@devguyio devguyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anishj0shi anishj0shi merged commit 4e608df into kyma-project:master Dec 30, 2019
@antoineco antoineco deleted the disable-knative-scaleto0 branch December 30, 2019 13:27
@anishj0shi anishj0shi mentioned this pull request Jan 2, 2020
Merged
kubadz pushed a commit to kubadz/kyma that referenced this pull request Jan 2, 2020
@antoineco @kubadz
event-sources: Disable Knative scale to 0 (kyma-project#6619)
a6c90ce 
* Set HTTPSource adapter's minscale value to 0

* Add comparison of Service template annotations
kubadz pushed a commit that referenced this pull request Jan 3, 2020
@antoineco @kubadz
event-sources: Disable Knative scale to 0 (#6619)
10d9646 
* Set HTTPSource adapter's minscale value to 0

* Add comparison of Service template annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devguyio devguyio devguyio approved these changes

@anishj0shi anishj0shi Awaiting requested review from anishj0shi

@joek joek Awaiting requested review from joek

@k15r k15r Awaiting requested review from k15r

@lilitgh lilitgh Awaiting requested review from lilitgh

@marcobebway marcobebway Awaiting requested review from marcobebway

@montaro montaro Awaiting requested review from montaro

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@rakesh-garimella rakesh-garimella Awaiting requested review from rakesh-garimella

@sayanh sayanh Awaiting requested review from sayanh

Assignees

@antoineco antoineco

Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoineco @devguyio @anishj0shi